From a919530cab64e3b2d4dfe412bf63c73db6ae8457 Mon Sep 17 00:00:00 2001
From: Josh Burman <jburman@yas.getyardstick.com>
Date: Wed, 27 Apr 2022 15:46:23 +0000
Subject: [PATCH] proper typing and bundle first ordering

---
 app/helpers/service_helper.py | 13 ++++++++++---
 app/models/bundle.py          |  3 +++
 app/models/item.py            |  1 +
 app/models/solver_run.py      | 10 +++++-----
 4 files changed, 19 insertions(+), 8 deletions(-)

diff --git a/app/helpers/service_helper.py b/app/helpers/service_helper.py
index cfae641..3617025 100644
--- a/app/helpers/service_helper.py
+++ b/app/helpers/service_helper.py
@@ -105,6 +105,8 @@ def key_to_uuid(key):
 
 def solution_items(variables: list, solver_run: SolverRun) -> Tuple[list]:
     form_items = []
+    form_bundles = []
+    final_items = []
     solver_variables = []
 
     for v in variables:
@@ -120,9 +122,14 @@ def solution_items(variables: list, solver_run: SolverRun) -> Tuple[list]:
                 bundle_id = v.name.replace('Bundle_', '')
                 bundle = solver_run.get_bundle(int(bundle_id))
 
-                if bundle:
-                    for item in bundle.items:
-                        if item: form_items.append(item)
+                if bundle: form_bundles.append(bundle)
+
+    for bundle in form_bundles:
+        for item in bundle.ordered_items:
+            final_items.append(item)
+
+    for item in form_items:
+        final_items.append(item)
 
     return form_items, solver_variables
 
diff --git a/app/models/bundle.py b/app/models/bundle.py
index 82fb127..7b15a9f 100644
--- a/app/models/bundle.py
+++ b/app/models/bundle.py
@@ -46,3 +46,6 @@ class Bundle(BaseModel):
             total += self.trf(solver_run.irt_model, target.theta)
 
         return total
+
+    def ordered_items(self) -> List[Item]:
+        return sorted(self.items, key=lambda x: x.position)
diff --git a/app/models/item.py b/app/models/item.py
index 260d612..f9f0a65 100644
--- a/app/models/item.py
+++ b/app/models/item.py
@@ -8,6 +8,7 @@ from lib.irt.item_information_function import ItemInformationFunction
 
 class Item(BaseModel):
     id: int
+    position: Optional[int]
     passage_id: Optional[int]
     workflow_state: Optional[str]
     attributes: List[Attribute]
diff --git a/app/models/solver_run.py b/app/models/solver_run.py
index ad54659..69550d0 100644
--- a/app/models/solver_run.py
+++ b/app/models/solver_run.py
@@ -14,7 +14,7 @@ from models.advanced_options import AdvancedOptions
 
 class SolverRun(BaseModel):
     items: List[Item] = []
-    bundles: list[Bundle] = []
+    bundles: List[Bundle] = []
     constraints: List[Constraint]
     irt_model: IRTModel
     objective_function: ObjectiveFunction
@@ -40,7 +40,7 @@ class SolverRun(BaseModel):
             if type == constraint.reference_attribute.type:
                 return constraint
 
-    def remove_items(self, items: list[Item]) -> bool:
+    def remove_items(self, items: List[Item]) -> bool:
         self.items = [item for item in self.items if item not in items]
         return True
 
@@ -100,7 +100,7 @@ class SolverRun(BaseModel):
         return next((constraint for constraint in self.constraints
                      if constraint.reference_attribute.id == name), None)
 
-    def unbundled_items(self) -> list:
+    def unbundled_items(self) -> List[Item]:
         # since the only bundles are based on passage id currently
         # in the future when we have more than just passage based bundles
         # we'll need to develop a more sophisticated way of handling this concern
@@ -113,7 +113,7 @@ class SolverRun(BaseModel):
         else:
             return self.items
 
-    def select_items_by_percent(self, percent: int) -> list[Item]:
+    def select_items_by_percent(self, percent: int) -> List[Item]:
         items = self.unbundled_items()
         total_items = len(items)
         selected_items_amount = round(total_items - (total_items *
@@ -121,7 +121,7 @@ class SolverRun(BaseModel):
 
         return random.sample(items, selected_items_amount)
 
-    def select_bundles_by_percent(self, percent: int) -> list[Bundle]:
+    def select_bundles_by_percent(self, percent: int) -> List[Bundle]:
         total_bundles = len(self.bundles)
         selected_bundles_amount = round(total_bundles - (total_bundles *
                                                          (percent / 100)))