added unit testing, and started implementing unit tests...phew

node_modules/@sinonjs/commons/lib/called-in-order.js

@@ -0,0 +1,34 @@
+"use strict";
+
+var every = require("./prototypes/array").every;
+
+function hasCallsLeft(callMap, spy) {
+    if (callMap[spy.id] === undefined) {
+        callMap[spy.id] = 0;
+    }
+
+    return callMap[spy.id] < spy.callCount;
+}
+
+function checkAdjacentCalls(callMap, spy, index, spies) {
+    var calledBeforeNext = true;
+
+    if (index !== spies.length - 1) {
+        calledBeforeNext = spy.calledBefore(spies[index + 1]);
+    }
+
+    if (hasCallsLeft(callMap, spy) && calledBeforeNext) {
+        callMap[spy.id] += 1;
+        return true;
+    }
+
+    return false;
+}
+
+module.exports = function calledInOrder(spies) {
+    var callMap = {};
+    // eslint-disable-next-line no-underscore-dangle
+    var _spies = arguments.length > 1 ? arguments : spies;
+
+    return every(_spies, checkAdjacentCalls.bind(null, callMap));
+};

node_modules/@sinonjs/commons/lib/called-in-order.test.js

@@ -0,0 +1,121 @@
+"use strict";
+
+var assert = require("@sinonjs/referee-sinon").assert;
+var calledInOrder = require("./called-in-order");
+var sinon = require("@sinonjs/referee-sinon").sinon;
+
+var testObject1 = {
+    someFunction: function() {
+        return;
+    }
+};
+var testObject2 = {
+    otherFunction: function() {
+        return;
+    }
+};
+var testObject3 = {
+    thirdFunction: function() {
+        return;
+    }
+};
+
+function testMethod() {
+    testObject1.someFunction();
+    testObject2.otherFunction();
+    testObject2.otherFunction();
+    testObject2.otherFunction();
+    testObject3.thirdFunction();
+}
+
+describe("calledInOrder", function() {
+    beforeEach(function() {
+        sinon.stub(testObject1, "someFunction");
+        sinon.stub(testObject2, "otherFunction");
+        sinon.stub(testObject3, "thirdFunction");
+        testMethod();
+    });
+    afterEach(function() {
+        testObject1.someFunction.restore();
+        testObject2.otherFunction.restore();
+        testObject3.thirdFunction.restore();
+    });
+
+    describe("given single array argument", function() {
+        describe("when stubs were called in expected order", function() {
+            it("returns true", function() {
+                assert.isTrue(
+                    calledInOrder([
+                        testObject1.someFunction,
+                        testObject2.otherFunction
+                    ])
+                );
+                assert.isTrue(
+                    calledInOrder([
+                        testObject1.someFunction,
+                        testObject2.otherFunction,
+                        testObject2.otherFunction,
+                        testObject3.thirdFunction
+                    ])
+                );
+            });
+        });
+
+        describe("when stubs were called in unexpected order", function() {
+            it("returns false", function() {
+                assert.isFalse(
+                    calledInOrder([
+                        testObject2.otherFunction,
+                        testObject1.someFunction
+                    ])
+                );
+                assert.isFalse(
+                    calledInOrder([
+                        testObject2.otherFunction,
+                        testObject1.someFunction,
+                        testObject1.someFunction,
+                        testObject3.thirdFunction
+                    ])
+                );
+            });
+        });
+    });
+
+    describe("given multiple arguments", function() {
+        describe("when stubs were called in expected order", function() {
+            it("returns true", function() {
+                assert.isTrue(
+                    calledInOrder(
+                        testObject1.someFunction,
+                        testObject2.otherFunction
+                    )
+                );
+                assert.isTrue(
+                    calledInOrder(
+                        testObject1.someFunction,
+                        testObject2.otherFunction,
+                        testObject3.thirdFunction
+                    )
+                );
+            });
+        });
+
+        describe("when stubs were called in unexpected order", function() {
+            it("returns false", function() {
+                assert.isFalse(
+                    calledInOrder(
+                        testObject2.otherFunction,
+                        testObject1.someFunction
+                    )
+                );
+                assert.isFalse(
+                    calledInOrder(
+                        testObject2.otherFunction,
+                        testObject1.someFunction,
+                        testObject3.thirdFunction
+                    )
+                );
+            });
+        });
+    });
+});

node_modules/@sinonjs/commons/lib/class-name.js

@@ -0,0 +1,19 @@
+"use strict";
+
+var functionName = require("./function-name");
+
+module.exports = function className(value) {
+    return (
+        (value.constructor && value.constructor.name) ||
+        // The next branch is for IE11 support only:
+        // Because the name property is not set on the prototype
+        // of the Function object, we finally try to grab the
+        // name from its definition. This will never be reached
+        // in node, so we are not able to test this properly.
+        // https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/name
+        (typeof value.constructor === "function" &&
+            /* istanbul ignore next */
+            functionName(value.constructor)) ||
+        null
+    );
+};

node_modules/@sinonjs/commons/lib/class-name.test.js

@@ -0,0 +1,37 @@
+"use strict";
+/* eslint-disable no-empty-function */
+
+var assert = require("@sinonjs/referee").assert;
+var className = require("./class-name");
+
+describe("className", function() {
+    it("returns the class name of an instance", function() {
+        // Because eslint-config-sinon disables es6, we can't
+        // use a class definition here
+        // https://github.com/sinonjs/eslint-config-sinon/blob/master/index.js
+        // var instance = new (class TestClass {})();
+        var instance = new function TestClass() {}();
+        var name = className(instance);
+        assert.equals(name, "TestClass");
+    });
+
+    it("returns 'Object' for {}", function() {
+        var name = className({});
+        assert.equals(name, "Object");
+    });
+
+    it("returns null for an object that has no prototype", function() {
+        var obj = Object.create(null);
+        var name = className(obj);
+        assert.equals(name, null);
+    });
+
+    it("returns null for an object whose prototype was mangled", function() {
+        // This is what Node v6 and v7 do for objects returned by querystring.parse()
+        function MangledObject() {}
+        MangledObject.prototype = Object.create(null);
+        var obj = new MangledObject();
+        var name = className(obj);
+        assert.equals(name, null);
+    });
+});

node_modules/@sinonjs/commons/lib/deprecated.js

@@ -0,0 +1,40 @@
+/* eslint-disable no-console */
+"use strict";
+
+// wrap returns a function that will invoke the supplied function and print a deprecation warning to the console each
+// time it is called.
+exports.wrap = function(func, msg) {
+    var wrapped = function() {
+        exports.printWarning(msg);
+        return func.apply(this, arguments);
+    };
+    if (func.prototype) {
+        wrapped.prototype = func.prototype;
+    }
+    return wrapped;
+};
+
+// defaultMsg returns a string which can be supplied to `wrap()` to notify the user that a particular part of the
+// sinon API has been deprecated.
+exports.defaultMsg = function(packageName, funcName) {
+    return (
+        packageName +
+        "." +
+        funcName +
+        " is deprecated and will be removed from the public API in a future version of " +
+        packageName +
+        "."
+    );
+};
+
+exports.printWarning = function(msg) {
+    // Watch out for IE7 and below! :(
+    /* istanbul ignore next */
+    if (typeof console !== "undefined") {
+        if (console.info) {
+            console.info(msg);
+        } else {
+            console.log(msg);
+        }
+    }
+};

node_modules/@sinonjs/commons/lib/deprecated.test.js

@@ -0,0 +1,86 @@
+/* eslint-disable no-console */
+"use strict";
+
+var assert = require("@sinonjs/referee-sinon").assert;
+var sinon = require("@sinonjs/referee-sinon").sinon;
+
+var deprecated = require("./deprecated");
+
+var msg = "test";
+
+describe("deprecated", function() {
+    describe("defaultMsg", function() {
+        it("should return a string", function() {
+            assert.equals(
+                deprecated.defaultMsg("sinon", "someFunc"),
+                "sinon.someFunc is deprecated and will be removed from the public API in a future version of sinon."
+            );
+        });
+    });
+
+    describe("printWarning", function() {
+        describe("when `console` is defined", function() {
+            beforeEach(function() {
+                sinon.replace(console, "info", sinon.fake());
+                sinon.replace(console, "log", sinon.fake());
+            });
+
+            afterEach(sinon.restore);
+
+            describe("when `console.info` is defined", function() {
+                it("shoudl call `console.info` with a message", function() {
+                    deprecated.printWarning(msg);
+                    assert.calledOnceWith(console.info, msg);
+                });
+            });
+
+            describe("when `console.info` is undefined", function() {
+                it("should call `console.log` with a message", function() {
+                    console.info = undefined;
+                    deprecated.printWarning(msg);
+                    assert.calledOnceWith(console.log, msg);
+                });
+            });
+        });
+    });
+
+    describe("wrap", function() {
+        var method = sinon.fake();
+        var wrapped;
+
+        beforeEach(function() {
+            wrapped = deprecated.wrap(method, msg);
+        });
+
+        it("should return a wrapper function", function() {
+            assert.match(wrapped, sinon.match.func);
+        });
+
+        it("should assign the prototype of the passed method", function() {
+            assert.equals(method.prototype, wrapped.prototype);
+        });
+
+        context("when the passed method has falsy prototype", function() {
+            it("should not be assigned to the wrapped method", function() {
+                method.prototype = null;
+                wrapped = deprecated.wrap(method, msg);
+                assert.match(wrapped.prototype, sinon.match.object);
+            });
+        });
+
+        context("when invoking the wrapped function", function() {
+            before(function() {
+                sinon.replace(deprecated, "printWarning", sinon.fake());
+                wrapped({});
+            });
+
+            it("should call `printWarning` before invoking", function() {
+                assert.calledOnceWith(deprecated.printWarning, msg);
+            });
+
+            it("should invoke the passed method with the given arguments", function() {
+                assert.calledOnceWith(method, {});
+            });
+        });
+    });
+});

node_modules/@sinonjs/commons/lib/every.js

@@ -0,0 +1,20 @@
+"use strict";
+
+// This is an `every` implementation that works for all iterables
+module.exports = function every(obj, fn) {
+    var pass = true;
+
+    try {
+        /* eslint-disable-next-line local-rules/no-prototype-methods */
+        obj.forEach(function() {
+            if (!fn.apply(this, arguments)) {
+                // Throwing an error is the only way to break `forEach`
+                throw new Error();
+            }
+        });
+    } catch (e) {
+        pass = false;
+    }
+
+    return pass;
+};

node_modules/@sinonjs/commons/lib/every.test.js

@@ -0,0 +1,41 @@
+"use strict";
+
+var assert = require("@sinonjs/referee-sinon").assert;
+var sinon = require("@sinonjs/referee-sinon").sinon;
+var every = require("./every");
+
+describe("util/core/every", function() {
+    it("returns true when the callback function returns true for every element in an iterable", function() {
+        var obj = [true, true, true, true];
+        var allTrue = every(obj, function(val) {
+            return val;
+        });
+
+        assert(allTrue);
+    });
+
+    it("returns false when the callback function returns false for any element in an iterable", function() {
+        var obj = [true, true, true, false];
+        var result = every(obj, function(val) {
+            return val;
+        });
+
+        assert.isFalse(result);
+    });
+
+    it("calls the given callback once for each item in an iterable until it returns false", function() {
+        var iterableOne = [true, true, true, true];
+        var iterableTwo = [true, true, false, true];
+        var callback = sinon.spy(function(val) {
+            return val;
+        });
+
+        every(iterableOne, callback);
+        assert.equals(callback.callCount, 4);
+
+        callback.resetHistory();
+
+        every(iterableTwo, callback);
+        assert.equals(callback.callCount, 3);
+    });
+});

node_modules/@sinonjs/commons/lib/function-name.js

@@ -0,0 +1,17 @@
+"use strict";
+
+module.exports = function functionName(func) {
+    if (!func) {
+        return "";
+    }
+
+    return (
+        func.displayName ||
+        func.name ||
+        // Use function decomposition as a last resort to get function
+        // name. Does not rely on function decomposition to work - if it
+        // doesn't debugging will be slightly less informative
+        // (i.e. toString will say 'spy' rather than 'myFunc').
+        (String(func).match(/function ([^\s(]+)/) || [])[1]
+    );
+};

node_modules/@sinonjs/commons/lib/function-name.test.js

@@ -0,0 +1,55 @@
+"use strict";
+
+var jsc = require("jsverify");
+var refute = require("@sinonjs/referee-sinon").refute;
+
+var functionName = require("./function-name");
+
+describe("function-name", function() {
+    it("should return empty string if func is falsy", function() {
+        jsc.assertForall("falsy", function(fn) {
+            return functionName(fn) === "";
+        });
+    });
+
+    it("should use displayName by default", function() {
+        jsc.assertForall("nestring", function(displayName) {
+            var fn = { displayName: displayName };
+
+            return functionName(fn) === fn.displayName;
+        });
+    });
+
+    it("should use name if displayName is not available", function() {
+        jsc.assertForall("nestring", function(name) {
+            var fn = { name: name };
+
+            return functionName(fn) === fn.name;
+        });
+    });
+
+    it("should fallback to string parsing", function() {
+        jsc.assertForall("nat", function(naturalNumber) {
+            var name = "fn" + naturalNumber;
+            var fn = {
+                toString: function() {
+                    return "\nfunction " + name;
+                }
+            };
+
+            return functionName(fn) === name;
+        });
+    });
+
+    it("should not fail when a name cannot be found", function() {
+        refute.exception(function() {
+            var fn = {
+                toString: function() {
+                    return "\nfunction (";
+                }
+            };
+
+            functionName(fn);
+        });
+    });
+});

node_modules/@sinonjs/commons/lib/index.js

@@ -0,0 +1,13 @@
+"use strict";
+
+module.exports = {
+    calledInOrder: require("./called-in-order"),
+    className: require("./class-name"),
+    deprecated: require("./deprecated"),
+    every: require("./every"),
+    functionName: require("./function-name"),
+    orderByFirstCall: require("./order-by-first-call"),
+    prototypes: require("./prototypes"),
+    typeOf: require("./type-of"),
+    valueToString: require("./value-to-string")
+};

node_modules/@sinonjs/commons/lib/index.test.js

@@ -0,0 +1,29 @@
+"use strict";
+
+var assert = require("@sinonjs/referee-sinon").assert;
+var index = require("./index");
+
+var expectedMethods = [
+    "calledInOrder",
+    "className",
+    "every",
+    "functionName",
+    "orderByFirstCall",
+    "typeOf",
+    "valueToString"
+];
+var expectedObjectProperties = ["deprecated", "prototypes"];
+
+describe("package", function() {
+    expectedMethods.forEach(function(name) {
+        it("should export a method named " + name, function() {
+            assert.isFunction(index[name]);
+        });
+    });
+
+    expectedObjectProperties.forEach(function(name) {
+        it("should export an object property named " + name, function() {
+            assert.isObject(index[name]);
+        });
+    });
+});

node_modules/@sinonjs/commons/lib/order-by-first-call.js

@@ -0,0 +1,18 @@
+"use strict";
+
+var sort = require("./prototypes/array").sort;
+var slice = require("./prototypes/array").slice;
+
+function comparator(a, b) {
+    // uuid, won't ever be equal
+    var aCall = a.getCall(0);
+    var bCall = b.getCall(0);
+    var aId = (aCall && aCall.callId) || -1;
+    var bId = (bCall && bCall.callId) || -1;
+
+    return aId < bId ? -1 : 1;
+}
+
+module.exports = function orderByFirstCall(spies) {
+    return sort(slice(spies), comparator);
+};

node_modules/@sinonjs/commons/lib/order-by-first-call.test.js

@@ -0,0 +1,52 @@
+"use strict";
+
+var assert = require("@sinonjs/referee-sinon").assert;
+var knuthShuffle = require("knuth-shuffle").knuthShuffle;
+var sinon = require("@sinonjs/referee-sinon").sinon;
+var orderByFirstCall = require("./order-by-first-call");
+
+describe("orderByFirstCall", function() {
+    it("should order an Array of spies by the callId of the first call, ascending", function() {
+        // create an array of spies
+        var spies = [
+            sinon.spy(),
+            sinon.spy(),
+            sinon.spy(),
+            sinon.spy(),
+            sinon.spy(),
+            sinon.spy()
+        ];
+
+        // call all the spies
+        spies.forEach(function(spy) {
+            spy();
+        });
+
+        // add a few uncalled spies
+        spies.push(sinon.spy());
+        spies.push(sinon.spy());
+
+        // randomise the order of the spies
+        knuthShuffle(spies);
+
+        var sortedSpies = orderByFirstCall(spies);
+
+        assert.equals(sortedSpies.length, spies.length);
+
+        var orderedByFirstCall = sortedSpies.every(function(spy, index) {
+            if (index + 1 === sortedSpies.length) {
+                return true;
+            }
+            var nextSpy = sortedSpies[index + 1];
+
+            // uncalled spies should be ordered first
+            if (!spy.called) {
+                return true;
+            }
+
+            return spy.calledImmediatelyBefore(nextSpy);
+        });
+
+        assert.isTrue(orderedByFirstCall);
+    });
+});

node_modules/@sinonjs/commons/lib/prototypes/README.md

@@ -0,0 +1,44 @@
+# Prototypes
+
+The functions in this folder are to be use for keeping cached references to the built-in prototypes, so that people can't inadvertently break the library by making mistakes in userland.
+
+See https://github.com/sinonjs/sinon/pull/1523
+
+## Without cached references
+
+```js
+// in userland, the library user needs to replace the filter method on
+// Array.prototype
+var array = [1, 2, 3];
+sinon.replace(array, "filter", sinon.fake.returns(2));
+
+// in a sinon module, the library author needs to use the filter method
+var someArray = ["a", "b", 42, "c"];
+var answer = filter(someArray, function(v) {
+    return v === 42;
+});
+
+console.log(answer);
+// => 2
+```
+
+
+## With cached references
+
+```js
+// in userland, the library user needs to replace the filter method on
+// Array.prototype
+var array = [1, 2, 3];
+sinon.replace(array, "filter", sinon.fake.returns(2));
+
+// in a sinon module, the library author needs to use the filter method
+// get a reference to the original Array.prototype.filter
+var filter = require("@sinonjs/commons").prototypes.array.filter;
+var someArray = ["a", "b", 42, "c"];
+var answer = filter(someArray, function(v) {
+    return v === 42;
+});
+
+console.log(answer);
+// => 42
+```

node_modules/@sinonjs/commons/lib/prototypes/array.js

@@ -0,0 +1,5 @@
+"use strict";
+
+var copyPrototype = require("./copy-prototype");
+
+module.exports = copyPrototype(Array.prototype);

node_modules/@sinonjs/commons/lib/prototypes/copy-prototype.js

@@ -0,0 +1,21 @@
+"use strict";
+
+var call = Function.call;
+
+module.exports = function copyPrototypeMethods(prototype) {
+    /* eslint-disable local-rules/no-prototype-methods */
+    return Object.getOwnPropertyNames(prototype).reduce(function(result, name) {
+        // ignore size because it throws from Map
+        if (
+            name !== "size" &&
+            name !== "caller" &&
+            name !== "callee" &&
+            name !== "arguments" &&
+            typeof prototype[name] === "function"
+        ) {
+            result[name] = call.bind(prototype[name]);
+        }
+
+        return result;
+    }, Object.create(null));
+};

node_modules/@sinonjs/commons/lib/prototypes/function.js

@@ -0,0 +1,5 @@
+"use strict";
+
+var copyPrototype = require("./copy-prototype");
+
+module.exports = copyPrototype(Function.prototype);

node_modules/@sinonjs/commons/lib/prototypes/index.js

@@ -0,0 +1,8 @@
+"use strict";
+
+module.exports = {
+    array: require("./array"),
+    function: require("./function"),
+    object: require("./object"),
+    string: require("./string")
+};

node_modules/@sinonjs/commons/lib/prototypes/index.test.js

@@ -0,0 +1,43 @@
+"use strict";
+
+var assert = require("@sinonjs/referee-sinon").assert;
+
+var arrayProto = require("./index").array;
+var functionProto = require("./index").function;
+var objectProto = require("./index").object;
+var stringProto = require("./index").string;
+
+describe("prototypes", function() {
+    describe(".array", function() {
+        verifyProperties(arrayProto, Array);
+    });
+    describe(".function", function() {
+        verifyProperties(functionProto, Function);
+    });
+    describe(".object", function() {
+        verifyProperties(objectProto, Object);
+    });
+    describe(".string", function() {
+        verifyProperties(stringProto, String);
+    });
+});
+
+function verifyProperties(p, origin) {
+    it("should have all the methods of the origin prototype", function() {
+        var methodNames = Object.getOwnPropertyNames(origin.prototype).filter(
+            function(name) {
+                return (
+                    name !== "size" &&
+                    name !== "caller" &&
+                    name !== "callee" &&
+                    name !== "arguments" &&
+                    typeof origin.prototype[name] === "function"
+                );
+            }
+        );
+
+        methodNames.forEach(function(name) {
+            assert.isTrue(Object.prototype.hasOwnProperty.call(p, name), name);
+        });
+    });
+}

node_modules/@sinonjs/commons/lib/prototypes/object.js

@@ -0,0 +1,5 @@
+"use strict";
+
+var copyPrototype = require("./copy-prototype");
+
+module.exports = copyPrototype(Object.prototype);

node_modules/@sinonjs/commons/lib/prototypes/string.js

@@ -0,0 +1,5 @@
+"use strict";
+
+var copyPrototype = require("./copy-prototype");
+
+module.exports = copyPrototype(String.prototype);

node_modules/@sinonjs/commons/lib/type-of.js

@@ -0,0 +1,7 @@
+"use strict";
+
+var type = require("type-detect");
+
+module.exports = function typeOf(value) {
+    return type(value).toLowerCase();
+};

node_modules/@sinonjs/commons/lib/type-of.test.js

@@ -0,0 +1,51 @@
+"use strict";
+
+var assert = require("@sinonjs/referee-sinon").assert;
+var typeOf = require("./type-of");
+
+describe("typeOf", function() {
+    it("returns boolean", function() {
+        assert.equals(typeOf(false), "boolean");
+    });
+
+    it("returns string", function() {
+        assert.equals(typeOf("Sinon.JS"), "string");
+    });
+
+    it("returns number", function() {
+        assert.equals(typeOf(123), "number");
+    });
+
+    it("returns object", function() {
+        assert.equals(typeOf({}), "object");
+    });
+
+    it("returns function", function() {
+        assert.equals(
+            typeOf(function() {
+                return undefined;
+            }),
+            "function"
+        );
+    });
+
+    it("returns undefined", function() {
+        assert.equals(typeOf(undefined), "undefined");
+    });
+
+    it("returns null", function() {
+        assert.equals(typeOf(null), "null");
+    });
+
+    it("returns array", function() {
+        assert.equals(typeOf([]), "array");
+    });
+
+    it("returns regexp", function() {
+        assert.equals(typeOf(/.*/), "regexp");
+    });
+
+    it("returns date", function() {
+        assert.equals(typeOf(new Date()), "date");
+    });
+});

node_modules/@sinonjs/commons/lib/value-to-string.js

@@ -0,0 +1,11 @@
+"use strict";
+
+function valueToString(value) {
+    if (value && value.toString) {
+        /* eslint-disable-next-line local-rules/no-prototype-methods */
+        return value.toString();
+    }
+    return String(value);
+}
+
+module.exports = valueToString;

node_modules/@sinonjs/commons/lib/value-to-string.test.js

@@ -0,0 +1,20 @@
+"use strict";
+
+var assert = require("@sinonjs/referee-sinon").assert;
+var valueToString = require("./value-to-string");
+
+describe("util/core/valueToString", function() {
+    it("returns string representation of an object", function() {
+        var obj = {};
+
+        assert.equals(valueToString(obj), obj.toString());
+    });
+
+    it("returns 'null' for literal null'", function() {
+        assert.equals(valueToString(null), "null");
+    });
+
+    it("returns 'undefined' for literal undefined", function() {
+        assert.equals(valueToString(undefined), "undefined");
+    });
+});